This repository has been archived by the owner on Apr 4, 2023. It is now read-only.
Add command for full-issuance/reissuances #351
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmc333333
force-pushed
the
26-full-issuance
branch
from
6a1cb3a to
8ebca9f
Compare
The pipeline command works by fetching all of the known "version"s of a regulation (i.e. identifiers), retrieving corresponding annual editions, and applying diffs based on final rules where annual editions aren't available. This approach has (at least) two holes regarding agencies releasing new CFR parts (or reissuing existing ones): * If an agency issues a new CFR part and modifies it within the same year, we will only have the content, in whole once (the annual edition will correspond to the modification). * If an agency re-issues a whole CFR part and then modifies it within a year of re-issuance, we'll run into a similar problem: the notice parser doesn't know how to understand a reissuance. This expands on the work started by @eadamsatx to create a command which will read a full CFR part from a specific notice. This requires a manual command, but makes it possible to account for the two situations above.
This wasn't a problem until `full_issuance` made these first rules "derived"
We don't need the isolated file system as we're writing to the db.
cmc333333
force-pushed
the
26-full-issuance
branch
from
8ebca9f to
4a2e4d3
Compare
Using the '//TAG' xpath searches the entire document, regardless of particular context, while './/TAG' will only search children of the current el. To check for children of the current el _or_ the current el, we need to use 'self::TAG|.//TAG'. This also modifies test cases to account for nested elements.
cmc333333
force-pushed
the
26-full-issuance
branch
from
4a2e4d3 to
faf090c
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A cleaned up version of navigo#1. Resolves #26 by adding a new command for parsing reissued/initial issuance of a whole CFR part.