This repository has been archived by the owner on Apr 4, 2023. It is now read-only.
Step 4 of separating out interpretations #349
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We had been special case-ing interpretations when replacing a marker within text. This uses a more generic strategy (i.e. inspecting the paragraph marker), which reduces dependencies.
Next step is to turn them into plugins.
Also rewrites the relevant tests to use py.test style
Also fixes an issue with the amendment plugins in setup.py
Also rewrites the associated test file to use py.test style
We don't actually use these pieces of grammar in the interp processing
cmc333333
force-pushed
the
separate-interp-4
branch
from
a64e9ce to
d5fadae
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Finishes out #336 by moving interpretation-specific amendment processing and tree building into plugins.