This repository has been archived by the owner on Apr 4, 2023. It is now read-only.
Standardize the tagged_text attribute #333
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We had been testing Node objects for the presence of the `tagged_text` attribute rather than defining that attribute consistently. Simplify a bunch of logic by using the attribute consistently. This _may_ require another change related to serialization; will see when the integration tests run.
…into standardize-tagged-text-attr
|
This is relatively low risk, so I'm going to go ahead and merge. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We had been testing Node objects for the presence of the
tagged_textattribute rather than defining that attribute consistently. Simplify a bunch
of logic by using the attribute consistently.
This may require another change related to serialization; will see when the
integration tests run.