add '-tag musl' build parameter to resolve confluent-kafka-go compatibility problem #94
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sixther-dc
force-pushed
the
feature/dc-dev
branch
4 times, most recently
from
9f90c3c to
80a081a
Compare
Codecov Report
@@ Coverage Diff @@
## develop #94 +/- ##
===========================================
- Coverage 10.64% 10.63% -0.01%
===========================================
Files 658 658
Lines 48738 48738
===========================================
- Hits 5186 5183 -3
- Misses 42900 42901 +1
- Partials 652 654 +2
|
sixther-dc
force-pushed
the
feature/dc-dev
branch
14 times, most recently
from
40b4307 to
8572ce8
Compare
sixther-dc
force-pushed
the
feature/dc-dev
branch
from
faedba3 to
c16e60b
Compare
innerpeacez
pushed a commit
to innerpeacez/erda
that referenced
this pull request
Apr 12, 2021
…ibility problem (erda-project#94) Co-authored-by: 段超 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
What this PR does / why we need it:
after we upgrade the version of confluent-kafka-go, it will cause the following compilation errors when building scheduler
It seems like it is linking the glibc librdkafka (which references __strdup).
build with -tags musl can use the built-in librdkafka。
confluentinc/confluent-kafka-go#454
Which issue(s) this PR fixes:
Fixes #
Specified Reivewers:
/assgin @luobily @recallsong