Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: group dependabot PRs #948

Merged
merged 6 commits into from
Jan 13, 2024

Conversation

ashnamehrotra
Copy link
Contributor

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, using fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when the PR gets merged):
Fixes #878

Special notes for your reviewer:

Signed-off-by: ashnamehrotra <[email protected]>
.github/dependabot.yml Outdated Show resolved Hide resolved
Signed-off-by: ashnamehrotra <[email protected]>
.github/dependabot.yml Outdated Show resolved Hide resolved
groups:
k8s:
patterns:
- "k8s.io/kubernetes"
Copy link
Member

@sozercan sozercan Jan 12, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is a single dependency. we can do k8s.io/* but we'll have to exclude cri. looks like we can have exclusions: https://docs.github.com/en/code-security/dependabot/dependabot-version-updates/configuration-options-for-the-dependabot.yml-file

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah got it! will change it to exclude cri

Signed-off-by: ashnamehrotra <[email protected]>
Copy link
Member

@sozercan sozercan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM

@sozercan sozercan merged commit e6a5683 into eraser-dev:main Jan 13, 2024
11 checks passed
ashnamehrotra added a commit to ashnamehrotra/eraser that referenced this pull request Jan 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

group dependabot prs
2 participants