Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: e2e get logs in relevant tests #800

Merged
merged 2 commits into from
Jul 28, 2023

Conversation

ashnamehrotra
Copy link
Contributor

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, using fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when the PR gets merged):
Fixes #776

Special notes for your reviewer:

@codecov-commenter
Copy link

codecov-commenter commented Jul 26, 2023

Codecov Report

Merging #800 (aeb3681) into main (575b3ef) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #800   +/-   ##
=======================================
  Coverage   14.83%   14.83%           
=======================================
  Files          13       13           
  Lines        1496     1496           
=======================================
  Hits          222      222           
  Misses       1253     1253           
  Partials       21       21           
Flag Coverage Δ
unittests 14.83% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@pmengelbert
Copy link
Contributor

LGTM, let's merge #773 first, then rebase this one.

Copy link
Contributor

@pmengelbert pmengelbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@ashnamehrotra ashnamehrotra merged commit 18a0f3c into eraser-dev:main Jul 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Get logs from all e2e tests
3 participants