Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Updating the wrong defaults in helm chart docs #1034

Merged
merged 4 commits into from
May 23, 2024

Conversation

akhilsaivenkata
Copy link
Contributor

What this PR does / why we need it: Updating the wrong defaults in helm chart docs

Which issue(s) this PR fixes (optional, using fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when the PR gets merged):
Fixes #1032

Special notes for your reviewer:

@sozercan
Copy link
Member

@akhilsaivenkata can you run make manifests and commit the changes too please? this is going to generate the values.yaml in manifest_staging. thanks!

@akhilsaivenkata
Copy link
Contributor Author

@akhilsaivenkata can you run make manifests and commit the changes too please? this is going to generate the values.yaml in manifest_staging. thanks!

Sure @sozercan . I will do that and commit those changes.

@akhilsaivenkata
Copy link
Contributor Author

akhilsaivenkata commented May 23, 2024

@akhilsaivenkata can you run make manifests and commit the changes too please? this is going to generate the values.yaml in manifest_staging. thanks!

@sozercan , I ran make manifests command and it has made changes to Readme.md in manifests_staging but it did not make any changes to values.yaml in manifests_staging, but I can see values.yaml in manifests_staging has already has our required changes.

I have pushed the new changes of Readme.md in manifests_staging. Is there anything I am missing here?

@sozercan
Copy link
Member

@akhilsaivenkata all good, this is my bad. i meant readme here

Copy link
Member

@sozercan sozercan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM

@sozercan sozercan merged commit 4a57e62 into eraser-dev:main May 23, 2024
86 of 88 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] wrong defaults in the helm chart docs
2 participants