Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support the Attachment object💡 #2616 #2622

Merged
merged 7 commits into from
Dec 9, 2024
Merged

Support the Attachment object💡 #2616 #2622

merged 7 commits into from
Dec 9, 2024

Conversation

robertbasti
Copy link
Collaborator

@robertbasti robertbasti commented Dec 4, 2024 •
edited
Loading

Fixes

This pull request fixes #2616

Description

added support of the Attachment object with tests and the common functionality

Type of change

  • Bugfix
  • New feature (non-breaking change which adds functionality)
  • Enhancement of existing functionality
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Impacted Areas in Application

  • Frontend
  • API
  • WITSML
  • Desktop
  • Other (please describe)

Checklist:

Communication

  • I have made corresponding changes to the documentation
  • PR affects application security

Code quality

  • I have self-reviewed my code
  • No new warnings are generated

Test coverage

  • New code is covered by passing tests

Further comments

@robertbasti robertbasti marked this pull request as draft December 4, 2024 14:00
@robertbasti robertbasti marked this pull request as ready for review December 4, 2024 14:55
eliasbruvik
eliasbruvik requested changes Dec 9, 2024
View reviewed changes
Tests/WitsmlExplorer.IntegrationTests/Resources/attachment.xml Show resolved Hide resolved
Src/Witsml/Data/WitsmlAttachment.cs Show resolved Hide resolved
Src/Witsml/Data/WitsmlAttachment.cs Show resolved Hide resolved
Src/WitsmlExplorer.Api/Models/Attachment.cs Outdated Show resolved Hide resolved
Src/WitsmlExplorer.Api/Models/EntityType.cs Outdated Show resolved Hide resolved
Tests/WitsmlExplorer.Api.Tests/Models/EntityTypeTests.cs Outdated Show resolved Hide resolved
eliasbruvik
eliasbruvik approved these changes Dec 9, 2024
View reviewed changes
Copy link
Contributor

@eliasbruvik eliasbruvik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewer checklist

  • Read issue and PR
  • Pulled branch and manually tested
  • Verify that PR resolves issue
  • Reviewed the code

@robertbasti robertbasti merged commit df1ef90 into equinor:main Dec 9, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eliasbruvik eliasbruvik eliasbruvik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support the Attachment object💡
2 participants
@robertbasti @eliasbruvik