build(deps): Upgrade to Deckgl 9.0.12 #2187
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hkfb
added
dependencies
- In general "picking_uActive" must be replaced by "picking.isActive". This is a float value. Also instances of "picking_uAttribute" must be replaced by "picking.isAttribute" (maplayer)
Also added implicit dependency @deck.gl-community/layers
nilscb
approved these changes
Aug 21, 2024
LeonidPolukhin
approved these changes
Aug 21, 2024
|
|
||
| if (!smoothShading || (normal[0] == 0.0 && normal[1] == 0.0 && normal[2] == 0.0)) { | ||
| normal = normalize(cross(dFdx(position_commonspace.xyz), dFdy(position_commonspace.xyz))); | ||
| } | ||
|
|
||
| //Picking pass. | ||
| if (picking_uActive && !picking_uAttribute) { | ||
| gl_FragColor = encodeVertexIndexToRGB(vertexIndex); | ||
| if (picking.isActive > 0.5 && !(picking.isAttribute > 0.5)) { |
There was a problem hiding this comment.
Why these checks are done like this? isActive and isAttribute are not booleans?
There was a problem hiding this comment.
They are floats now. Used to be booleans.
|
🎉 This issue has been resolved in version [email protected] 🎉 The release is available on GitHub release |
|
🎉 This issue has been resolved in version [email protected] 🎉 The release is available on GitHub release |
|
🎉 This issue has been resolved in version [email protected] 🎉 The release is available on GitHub release |
|
🎉 This issue has been resolved in version [email protected] 🎉 The release is available on GitHub release |
|
🎉 This issue has been resolved in version [email protected] 🎉 The release is available on GitHub release |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.