Split mono-repo in different `npm` packages #1543

anders-kiaer · 2023-06-08T09:59:13Z

Partially solves #1493.

Move component source code to separate folders. @anders-kiaer
Split runtime dependencies in current single package.json into each components package.json. @anders-kiaer
Use ~~lerna~~ nx @anders-kiaer
One single tsconfig.json in root folder (looks like this is not fully possible Set TypeScript compiler's base/working directory microsoft/TypeScript#25430, but we can put most of the config in the root folder by extending it in each package). @anders-kiaer
Keep dev-dependencies in root for consistency across packages (?). @anders-kiaer
Ensure build of common components runs to completion... i.e. npx nx build group-tree or npx nx run group-tree:build (and subsurface-viewer, well-completions, well-log-viewer) @hkfb
Ensure generated packages are usable... still need to find how to generate publishable libraries :/
Rename top-folder from /react to /typescript.

After discussion with @hkfb we think that we will postpone the following three tasks to a later PR:

Adjust storybook setup such that we can keep ONE storybook to publish containing stories of all the components.
Adjust CI setup to succeed with new structure.
Adjust Dash build setup to work with nx and multiple packages.
Remove unused (dev)dependencies in root workspace package.json

Add missing inputSchema and example-data

react/packages/subsurface-viewer/package.json

w1nklr · 2023-06-19T16:15:45Z

there is still a react/src/lib directories holding files. I guess these need to be handled and dispatched to the corresponding workspaces.

…1552) * Refactor Map.tsx to be more efficient with use of hooks (useRef) * Refactor Map.tsx to be more efficient with use of hooks (useRef) * Fix scaling with arrow keys. Had to split one useEffect into two; one for changes in layers and one for changes to scaling. * Uppdate tests. * Just changed the order of the effect * Split mono-repo in different `npm` packages (#1543) * Refactor Map.tsx to be more efficient with use of hooks (useRef) * Fix scaling with arrow keys. Had to split one useEffect into two; one for changes in layers and one for changes to scaling. * Uppdate tests. * Just changed the order of the effect * Refactor Map.tsx to be more efficient with use of hooks (useRef) * Fix scaling with arrow keys. Had to split one useEffect into two; one for changes in layers and one for changes to scaling. * Uppdate tests. * Just changed the order of the effect * Refactor Map.tsx to be more efficient with use of hooks (useRef) * Fix scaling with arrow keys. Had to split one useEffect into two; one for changes in layers and one for changes to scaling. * Just changed the order of the effect * fix inculde path * Restore storybook (#1563) * Restored example-data for storybook. * Fixed staticDirs reference in storybook config. * Fixed story paths. * Fixed references to example-data directory. * Fixed storybook staticDirs reference. * Try to prevent package build race condition. * Fixed package transpilations. --------- Co-authored-by: Havard Bjerke <[email protected]> * Refactor Map.tsx to be more efficient with use of hooks (useRef) * Fix scaling with arrow keys. Had to split one useEffect into two; one for changes in layers and one for changes to scaling. * Uppdate tests. * Just changed the order of the effect * Refactor Map.tsx to be more efficient with use of hooks (useRef) * Fix scaling with arrow keys. Had to split one useEffect into two; one for changes in layers and one for changes to scaling. * Uppdate tests. * Just changed the order of the effect * Refactor Map.tsx to be more efficient with use of hooks (useRef) * Fix scaling with arrow keys. Had to split one useEffect into two; one for changes in layers and one for changes to scaling. * Just changed the order of the effect * fix inculde path * Refactor Map.tsx to be more efficient with use of hooks (useRef) * Fix scaling with arrow keys. Had to split one useEffect into two; one for changes in layers and one for changes to scaling. * Just changed the order of the effect * Fix include --------- Co-authored-by: Anders Fredrik Kiær <[email protected]> Co-authored-by: Håvard Bjerke <[email protected]> Co-authored-by: Havard Bjerke <[email protected]>

* Fix of "Prevent nested ternaries in the code #1526" * Added comment to explain rule settings * Use "error" in stead of number 2 in rule. * Split mono-repo in different `npm` packages (#1543) * Restore storybook (#1563) * Restored example-data for storybook. * Fixed staticDirs reference in storybook config. * Fixed story paths. * Fixed references to example-data directory. * Fixed storybook staticDirs reference. * Try to prevent package build race condition. * Fixed package transpilations. --------- Co-authored-by: Havard Bjerke <[email protected]> * Refactor Map.tsx to be more efficient with use of hooks (useEffect) (#1552) * Refactor Map.tsx to be more efficient with use of hooks (useRef) * Refactor Map.tsx to be more efficient with use of hooks (useRef) * Fix scaling with arrow keys. Had to split one useEffect into two; one for changes in layers and one for changes to scaling. * Uppdate tests. * Just changed the order of the effect * Split mono-repo in different `npm` packages (#1543) * Refactor Map.tsx to be more efficient with use of hooks (useRef) * Fix scaling with arrow keys. Had to split one useEffect into two; one for changes in layers and one for changes to scaling. * Uppdate tests. * Just changed the order of the effect * Refactor Map.tsx to be more efficient with use of hooks (useRef) * Fix scaling with arrow keys. Had to split one useEffect into two; one for changes in layers and one for changes to scaling. * Uppdate tests. * Just changed the order of the effect * Refactor Map.tsx to be more efficient with use of hooks (useRef) * Fix scaling with arrow keys. Had to split one useEffect into two; one for changes in layers and one for changes to scaling. * Just changed the order of the effect * fix inculde path * Restore storybook (#1563) * Restored example-data for storybook. * Fixed staticDirs reference in storybook config. * Fixed story paths. * Fixed references to example-data directory. * Fixed storybook staticDirs reference. * Try to prevent package build race condition. * Fixed package transpilations. --------- Co-authored-by: Havard Bjerke <[email protected]> * Refactor Map.tsx to be more efficient with use of hooks (useRef) * Fix scaling with arrow keys. Had to split one useEffect into two; one for changes in layers and one for changes to scaling. * Uppdate tests. * Just changed the order of the effect * Refactor Map.tsx to be more efficient with use of hooks (useRef) * Fix scaling with arrow keys. Had to split one useEffect into two; one for changes in layers and one for changes to scaling. * Uppdate tests. * Just changed the order of the effect * Refactor Map.tsx to be more efficient with use of hooks (useRef) * Fix scaling with arrow keys. Had to split one useEffect into two; one for changes in layers and one for changes to scaling. * Just changed the order of the effect * fix inculde path * Refactor Map.tsx to be more efficient with use of hooks (useRef) * Fix scaling with arrow keys. Had to split one useEffect into two; one for changes in layers and one for changes to scaling. * Just changed the order of the effect * Fix include --------- Co-authored-by: Anders Fredrik Kiær <[email protected]> Co-authored-by: Håvard Bjerke <[email protected]> Co-authored-by: Havard Bjerke <[email protected]> * Z scaling fix (#1555) * Refactor Map.tsx to be more efficient with use of hooks (useRef) * Fix scaling with arrow keys. Had to split one useEffect into two; one for changes in layers and one for changes to scaling. * Just changed the order of the effect * Refactor Map.tsx to be more efficient with use of hooks (useRef) * Fix scaling with arrow keys. Had to split one useEffect into two; one for changes in layers and one for changes to scaling. * Just changed the order of the effect * Refactor Map.tsx to be more efficient with use of hooks (useRef) * Fix scaling with arrow keys. Had to split one useEffect into two; one for changes in layers and one for changes to scaling. * Just changed the order of the effect * fix inculde path * Refactor Map.tsx to be more efficient with use of hooks (useRef) * Fix scaling with arrow keys. Had to split one useEffect into two; one for changes in layers and one for changes to scaling. * Just changed the order of the effect * Refactor Map.tsx to be more efficient with use of hooks (useRef) * Fix scaling with arrow keys. Had to split one useEffect into two; one for changes in layers and one for changes to scaling. * Just changed the order of the effect * Refactor Map.tsx to be more efficient with use of hooks (useRef) * Fix scaling with arrow keys. Had to split one useEffect into two; one for changes in layers and one for changes to scaling. * Just changed the order of the effect * Refactor Map.tsx to be more efficient with use of hooks (useRef) * Fix scaling with arrow keys. Had to split one useEffect into two; one for changes in layers and one for changes to scaling. * Just changed the order of the effect * fix inculde path * Refactor Map.tsx to be more efficient with use of hooks (useRef) * Fix scaling with arrow keys. Had to split one useEffect into two; one for changes in layers and one for changes to scaling. * Just changed the order of the effect * Fix include * Fix of "The Z scaling in webviz is slightly off initially. #1554" * Updated test snapshots. * Updated test snapshots. * Fix of "[NGRM] - Visual artifacts shown after setting incorrect matri… (#1547) * Refactor Map.tsx to be more efficient with use of hooks (useRef) * Fix scaling with arrow keys. Had to split one useEffect into two; one for changes in layers and one for changes to scaling. * Uppdate tests. * Just changed the order of the effect * Refactor Map.tsx to be more efficient with use of hooks (useRef) * Fix scaling with arrow keys. Had to split one useEffect into two; one for changes in layers and one for changes to scaling. * Uppdate tests. * Just changed the order of the effect * Refactor Map.tsx to be more efficient with use of hooks (useRef) * Fix scaling with arrow keys. Had to split one useEffect into two; one for changes in layers and one for changes to scaling. * Just changed the order of the effect * fix inculde path * Refactor Map.tsx to be more efficient with use of hooks (useRef) * Fix scaling with arrow keys. Had to split one useEffect into two; one for changes in layers and one for changes to scaling. * Just changed the order of the effect * Refactor Map.tsx to be more efficient with use of hooks (useRef) * Fix scaling with arrow keys. Had to split one useEffect into two; one for changes in layers and one for changes to scaling. * Just changed the order of the effect * Refactor Map.tsx to be more efficient with use of hooks (useRef) * Fix scaling with arrow keys. Had to split one useEffect into two; one for changes in layers and one for changes to scaling. * Just changed the order of the effect * Refactor Map.tsx to be more efficient with use of hooks (useRef) * Fix scaling with arrow keys. Had to split one useEffect into two; one for changes in layers and one for changes to scaling. * Just changed the order of the effect * fix inculde path * Refactor Map.tsx to be more efficient with use of hooks (useRef) * Fix scaling with arrow keys. Had to split one useEffect into two; one for changes in layers and one for changes to scaling. * Just changed the order of the effect * Fix include * Fix of "The Z scaling in webviz is slightly off initially. #1554" * Updated test snapshots. * Updated test snapshots. * Fix of "[NGRM] - Visual artifacts shown after setting incorrect matrix layout size number #1477" * Changed error to warning. * Fix of "[NGRM] - Visual artifacts shown after setting incorrect matrix layout size number #1477" * Fix of "[NGRM] - Visual artifacts shown after setting incorrect matrix layout size number #1477" * Small fix * Migrate to Storybook 7 (#1568) * Upgrade storybook to latest. * Updated storybook config. * Migrate to Storybook v7. * Bump to latest color-tables. * Removed @storybook/react-vite dependency. --------- Co-authored-by: Havard Bjerke <[email protected]> * Deploy storybook on merge to `master` (#1570) * Fix of "Crash in story "ViewMatrixMargin" #1571" (#1572) * Fix of "Prevent nested ternaries in the code #1526" * Added comment to explain rule settings * Use "error" in stead of number 2 in rule. --------- Co-authored-by: Anders Fredrik Kiær <[email protected]> Co-authored-by: Håvard Bjerke <[email protected]> Co-authored-by: Havard Bjerke <[email protected]>

hkfb · 2023-09-20T13:17:45Z