Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: create reduced availability alert #98

Draft
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

hknutsen
Copy link
Member

BREAKING CHANGE: add required variable action_group_id

BREAKING CHANGE: add required variable `action_group_id`
@hknutsen

This comment was marked as outdated.

@hknutsen hknutsen marked this pull request as ready for review October 30, 2024 10:08
@hknutsen hknutsen requested a review from a team as a code owner October 30, 2024 10:08
@hknutsen
Copy link
Member Author

@equinor/terraform-baseline-maintainers Should I write a more detailed migration guide, for example in a document docs/migrate-to-v12.md?

@helenakallekleiv
Copy link
Contributor

@equinor/terraform-baseline-maintainers Should I write a more detailed migration guide, for example in a document docs/migrate-to-v12.md?

I think that could be helpful, yes!
Do you want to include the migration guide in this PR, or in a new one?

Copy link
Contributor

@helenakallekleiv helenakallekleiv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is very good as is, but a migration guide as you suggested could be beneficial!

@sebastianlolv
Copy link
Contributor

@hknutsen Is this on hold to create the migration guide or will you make seperate PR?

@hknutsen
Copy link
Member Author

Converting to draft again to discuss even further. Still scared that this might lead to feature creep.

@hknutsen hknutsen marked this pull request as draft November 25, 2024 07:29
Copy link
Contributor

There has been no activity on this pull request for 60 days. stale label will be added. If no additional activity occurs, the pull request will be closed in 7 days.

@github-actions github-actions bot added the stale label Jan 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants