Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove tox #622

Merged
merged 2 commits into from
Jun 11, 2024
Merged

Remove tox #622

merged 2 commits into from
Jun 11, 2024

Conversation

larsevj
Copy link
Contributor

@larsevj larsevj commented Jun 11, 2024

No description provided.

@larsevj larsevj force-pushed the remove_tox branch 2 times, most recently from 943aed8 to e0d8555 Compare June 11, 2024 09:48
@larsevj
Copy link
Contributor Author

larsevj commented Jun 11, 2024 •
edited
Loading

A bit unsure about this one:

pip install ".[style]"
pre-commit run --all-files

You need also install .[test] to make pre-commit pass on test files. Pylint will fail on missing pytest if not.

@larsevj larsevj force-pushed the remove_tox branch 3 times, most recently from 9d14ebf to b259d79 Compare June 11, 2024 10:59
oyvindeide
oyvindeide approved these changes Jun 11, 2024
View reviewed changes
Copy link
Contributor

@oyvindeide oyvindeide left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@larsevj larsevj merged commit e79f0f5 into main Jun 11, 2024
10 checks passed
@larsevj larsevj deleted the remove_tox branch June 11, 2024 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oyvindeide oyvindeide oyvindeide approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@larsevj @oyvindeide