Improve unformatted reading performance #52
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eivindjahren
force-pushed
the
improve_performance
branch
3 times, most recently
from
875ad51 to
3dbf4ae
Compare
eivindjahren
force-pushed
the
improve_performance
branch
from
3dbf4ae to
019d2ee
Compare
eivindjahren
added a commit
to eivindjahren/ert
that referenced
this pull request
Jan 4, 2024
keys_as_bytes is dependent on equinor/resfo#52
eivindjahren
force-pushed
the
improve_performance
branch
from
019d2ee to
1bdcf6c
Compare
oyvindeide
approved these changes
Jan 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bytes_in_arrayis called quite often. By inlining some function calls, reading performance is increased dramatically for files with large amounts of keys.