Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to ruff #430

Merged
merged 2 commits into from
Jan 31, 2024
Merged

Switch to ruff #430

merged 2 commits into from
Jan 31, 2024

Conversation

alifbe
Copy link
Collaborator

@alifbe alifbe commented Jan 29, 2024

@alifbe alifbe requested review from mferrera and berland January 29, 2024 14:25
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (2a8cfa8) 98.77% compared to head (29e9a3e) 98.80%.

❗ Current head 29e9a3e differs from pull request most recent head 846350c. Consider uploading reports for the commit 846350c to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #430      +/-   ##
==========================================
+ Coverage   98.77%   98.80%   +0.02%     
==========================================
  Files          17       17              
  Lines        2701     2682      -19     
==========================================
- Hits         2668     2650      -18     
+ Misses         33       32       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@mferrera mferrera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm a bit concerned about performance implications of removing inplace=True from the dataframes. Maybe @berland should comment about this (he may also object to removing pylint stuff)

pyscal/__init__.py Outdated Show resolved Hide resolved
pyscal/factory.py Outdated Show resolved Hide resolved
pyscal/factory.py Outdated Show resolved Hide resolved
pyscal/gasoil.py Show resolved Hide resolved
@alifbe
Copy link
Collaborator Author

alifbe commented Jan 30, 2024

I'm a bit concerned about performance implications of removing inplace=True from the dataframes. Maybe @berland should comment about this (he may also object to removing pylint stuff)

I didn't know that ruff doesn't replace pylint 😊

It seems like there are quite a few issues in main branch found by pylint. Instead of putting it back here, I am thinking to solve it in another PR. Created issue #431

@mferrera
Copy link
Collaborator

For what it's worth, I think pylint is typically used to get a sense of some code quality or improvements rather than making sure code satisfies all of its conditions. You'll almost never see pylint included in linting CI workflows for that reason. It's a good barometer but not necessarily a bar to meet.

@alifbe alifbe merged commit c55ed28 into equinor:main Jan 31, 2024
10 checks passed
@alifbe alifbe deleted the use-ruff branch January 31, 2024 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use ruff for code formatting/linting
3 participants