-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch to ruff #430
Switch to ruff #430
Conversation
alifbe
commented
Jan 29, 2024
•
edited
Loading
edited
- Use ruff for code linting and formatting close Use ruff for code formatting/linting #429
- Update contributing documentation
- Remove sphinx pin
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #430 +/- ##
==========================================
+ Coverage 98.77% 98.80% +0.02%
==========================================
Files 17 17
Lines 2701 2682 -19
==========================================
- Hits 2668 2650 -18
+ Misses 33 32 -1 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm a bit concerned about performance implications of removing inplace=True
from the dataframes. Maybe @berland should comment about this (he may also object to removing pylint stuff)
I didn't know that It seems like there are quite a few issues in main branch found by |
For what it's worth, I think pylint is typically used to get a sense of some code quality or improvements rather than making sure code satisfies all of its conditions. You'll almost never see pylint included in linting CI workflows for that reason. It's a good barometer but not necessarily a bar to meet. |