Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adapt nightly tests to new aggregation rules; must have more than 1 realization #318

Merged
merged 2 commits into from
Apr 26, 2024
Merged

Adapt nightly tests to new aggregation rules; must have more than 1 realization #318

merged 2 commits into from
Apr 26, 2024

Conversation

roywilly
Copy link
Contributor

Issue

Link to the issue resolved by this PR.

Short description

Short description of the approach taken to solve the issue

Pre-review checklist

  • Read through all changes. No redundant print() statements, commented-out code, or other remnants from the development. 👀
  • Make sure tests pass after every commit. ✅
  • New/refactored code is following same conventions as the rest of the code base. 🧬
  • New/refactored code is tested. ⚙
  • Documentation has been updated 🧾

Pre-merge checklist

  • Commit history is consistent and clean. 👌

@roywilly roywilly requested a review from a team April 25, 2024 12:28
rwiker
rwiker previously approved these changes Apr 25, 2024
View reviewed changes
Copy link
Contributor

@rwiker rwiker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

equinor-ruaj
equinor-ruaj previously approved these changes Apr 25, 2024
View reviewed changes
Copy link
Contributor

@equinor-ruaj equinor-ruaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@roywilly roywilly dismissed stale reviews from equinor-ruaj and rwiker via 192e1f3 April 26, 2024 06:30
@roywilly roywilly requested review from rwiker and equinor-ruaj April 26, 2024 06:30
rwiker
rwiker approved these changes Apr 26, 2024
View reviewed changes
Copy link
Contributor

@rwiker rwiker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@roywilly roywilly merged commit 576140b into main Apr 26, 2024
17 of 24 checks passed
@roywilly roywilly deleted the only-aggregate-when-multiple-realizations branch May 29, 2024 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rwiker rwiker rwiker approved these changes

@equinor-ruaj equinor-ruaj Awaiting requested review from equinor-ruaj

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@roywilly @rwiker @equinor-ruaj