Enable filter on data.content. #310
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
perolavsvendsen
commented
Mar 23, 2024
perolavsvendsen
commented
Mar 23, 2024
perolavsvendsen
commented
Mar 23, 2024
| @@ -23,6 +24,11 @@ def name(self) -> str: | |||
| """Object name""" | |||
| return self._get_property(["data", "name"]) | |||
|
|
|||
| @property | |||
There was a problem hiding this comment.
Main change in this PR: Add content property to the child object.
rwiker
reviewed
Mar 25, 2024
| @@ -243,7 +249,7 @@ The `SurfaceCollection.filter` method takes the following parameters: | |||
|
|
|||
| * uuid | |||
| * name | |||
| * tagname | |||
There was a problem hiding this comment.
Is it intentional to remove tagname?
There was a problem hiding this comment.
Yes, intentional. It is a non-standardized freetext field, which will turn into a major problem down the road. So trying to nudge people away from using it. But it is there, so perhaps it should be in the docs. And it has to be there, because there is no uniqueness without it.
So perhaps this was a bad call 🤷
There was a problem hiding this comment.
Put tagname back in
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
#249
Short description
data.contentis a key metadata attribute. Unlike non-standard freetext attributes such as "tagname" and others which should never be used for logical operations, thedata.contentis standardized. Therefore, we want to promote usage ofdata.contentas much as possible.This PR should enable explorer to filter on
data.content.Pre-review checklist
print()statements, commented-out code, or other remnants from the development. 👀Pre-merge checklist