Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only print THPRES between neighboring equil regions #403

Merged
merged 3 commits into from
May 10, 2021
Merged

Only print THPRES between neighboring equil regions #403

merged 3 commits into from
May 10, 2021

Conversation

olelod
Copy link
Collaborator

@olelod olelod commented May 10, 2021 •
edited
Loading

There is currently a bug in the code that prints threshold pressures between all flow tubes if there is more than one equilibrium region. Thus many threshold pressures are added within one equilibrium region as well (probably from when individual and global were the only available options). This PR makes it such that THPRES is only printed for neighboring equilibrium regions (sorted for readability).

Contributor checklist

  • 🎉 This PR closes Assign THPRES values per region of the reference model #400.
  • 📜 I have broken down my PR into the following tasks:
    • Add conversion from finding combination of tubes connected at nodes to find combination of regions connected at nodes
  • 🤖 I have added tests, or extended existing tests, to cover any new features or bugs fixed in this PR.
  • 📖 I have considered adding a new entry in CHANGELOG.md.
  • 📚 I have considered updating the documentation.

@olelod olelod added the bug Something isn't working label May 10, 2021
@olelod olelod added this to the HM open Norne Model milestone May 10, 2021
@olelod olelod self-assigned this May 10, 2021
@olelod olelod marked this pull request as ready for review May 10, 2021 11:55
wouterjdb
wouterjdb approved these changes May 10, 2021
View reviewed changes
Copy link
Collaborator

@wouterjdb wouterjdb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@olelod olelod merged commit de23dc0 into master May 10, 2021
@olelod olelod deleted the i400-thpres-per-region branch May 10, 2021 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wouterjdb wouterjdb wouterjdb approved these changes

@anders-kiaer anders-kiaer Awaiting requested review from anders-kiaer

Assignees

@olelod olelod

Labels
bug Something isn't working
Projects
None yet
Milestone
HM open Norne Model
Development

Successfully merging this pull request may close these issues.

Assign THPRES values per region of the reference model
2 participants
@olelod @wouterjdb