Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Distribute model volume to nearest tube cell midpoint #401

Merged
merged 2 commits into from
May 7, 2021

Conversation

wouterjdb
Copy link
Collaborator

@wouterjdb wouterjdb commented May 7, 2021

This PR changes the way volume from an original simulation model is distributed to FlowNet. Instead of distributing to the mid point of all tubes the volume is distributed to the midpoint of all tube cell mid points.

The volumes distributed to flownet tube cells are then summed per tube, and evenly redistributed over the single tube.


Contributor checklist

  • 🎉 This PR closes Too much volume assigned to (short?) tubes #395.
  • 📜 I have broken down my PR into the following tasks:
    • Change algorithm
    • Test
  • 🤖 I have added tests, or extended existing tests, to cover any new features or bugs fixed in this PR.
  • 📖 I have considered adding a new entry in CHANGELOG.md.
  • 📚 I have considered updating the documentation.

@wouterjdb wouterjdb added enhancement New feature or request invalid This doesn't seem right labels May 7, 2021
@wouterjdb wouterjdb added this to the HM open Norne Model milestone May 7, 2021
@wouterjdb wouterjdb self-assigned this May 7, 2021
@wouterjdb
Copy link
Collaborator Author

wouterjdb commented May 7, 2021

Comparison of volumes (identical color scales):

Old method
image

New method
image

Observations:
The total distributed volume is similar (6.3e8 vs 6.5e8); minor differences are to be expected due to differences is porosity and bulk volume multipliers being different. Using the new distribution scheme there are no extreme outliers anymore for short vertical connections.

The following plot shows the volume distribution using the new algorithm, but now with a color scale that matches better with the assigned volumes.

image

Some outliers can still be observed, but the outlier that has the highest volume per cell has less than 40% of the volume that was previously assigned to the largest grid cell - and there are fewer outliers. This suggest that all-in-all the volume is more evenly distributed (as in, a better approximation of the original model).

Looking at the statistics, the new method has a similar P10, mean and P90 values for the distribution (but keep in mind that number of cells are not 100% identical). However, again, the maximum values has significantly reduces - the outliers are reduced.

image

@wouterjdb wouterjdb marked this pull request as ready for review May 7, 2021 09:54
Copy link
Collaborator

@olelod olelod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wouterjdb wouterjdb merged commit 8fc3fe3 into equinor:master May 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request invalid This doesn't seem right
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Too much volume assigned to (short?) tubes
2 participants