-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added option to run multiple analytics workflows during history matching #337
Added option to run multiple analytics workflows during history matching #337
Conversation
@wouterjdb , I did not get a request for review. But I did find a solution to allow it to work for
Let's continue tomorrow. Hopefully we can merge this PR still in the morning |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code-wise, LGTM! Do not forget to revert .github/workflows/flownet.yml
back to equinor:master
.
I have checked the CI checks with your flownet-testdata
branch and the workflow fails (never gets to [Done]
) because the config files there have quantity: [WOPR:BR-P-, ...]
, so it falls into the fix of the next PR. But I guess that you have verified that this is the only issue.
One thing is: we should maybe add a comment somewhere making explicitly clear that the hyperopt
option will use settings of the first instance of the analysis
list.
This PR adds the option to include multiple analytics workflows in the FlowNet config, like so:
This is a ❗ breaking change ❗ as you now must define the analysis workflows as list items under the
analysis
keyword.A new issue was identified during this work #338.
Contributor checklist
CHANGELOG.md
.