Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

i290 Adapt perforation strategy to layers #296

Merged
merged 9 commits into from
Jan 15, 2021
Merged

i290 Adapt perforation strategy to layers #296

merged 9 commits into from
Jan 15, 2021

Conversation

LonnekevB
Copy link
Contributor

@LonnekevB LonnekevB commented Jan 7, 2021 •
edited by wouterjdb
Loading

Insert a description of your pull request (PR) here, and check off the boxes below when they are done.

Contributor checklist

  • 🎉 This PR closes Adapt perforation strategy to work with layering #290
  • 📜 I have broken down my PR into the following tasks:
    • Task 1
    • Task 2
  • 🤖 I have added tests, or extended existing tests, to cover any new features or bugs fixed in this PR.
  • 📖 I have considered adding a new entry in CHANGELOG.md.
  • 📚 I have considered updating the documentation.

@wouterjdb wouterjdb added the enhancement New feature or request label Jan 7, 2021
@LonnekevB
LAYER_ID now recognized in bottom_point, top_point, multiple and mult…
b9bc789 
…iple_based_on_workovers perforation strategies
@LonnekevB LonnekevB mentioned this pull request Jan 8, 2021
Closed
@wouterjdb wouterjdb mentioned this pull request Jan 14, 2021
Closed
7 tasks
@LonnekevB LonnekevB marked this pull request as ready for review January 14, 2021 15:27
wouterjdb
wouterjdb approved these changes Jan 14, 2021
View reviewed changes
Copy link
Collaborator

@wouterjdb wouterjdb left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 (could be good to modify the changelog and document these changes though)

@wouterjdb wouterjdb merged commit 2e44905 into equinor:master Jan 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wouterjdb wouterjdb wouterjdb approved these changes

@anders-kiaer anders-kiaer Awaiting requested review from anders-kiaer

@olelod olelod Awaiting requested review from olelod olelod is a code owner

Assignees

@LonnekevB LonnekevB

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Adapt perforation strategy to work with layering
2 participants
@LonnekevB @wouterjdb