Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove un-needed code after 30f2fb9 #9946

Merged
merged 1 commit into from
Feb 3, 2025

Conversation

berland
Copy link
Contributor

@berland berland commented Feb 3, 2025

Issue
Resolves three dead lines.

Approach
✂️

  • PR title captures the intent of the changes, and is fitting for release notes.
  • Added appropriate release note label
  • Commit history is consistent and clean, in line with the contribution guidelines.
  • Make sure unit tests pass locally after every commit (git rebase -i main --exec 'just rapid-tests')

When applicable

  • When there are user facing changes: Updated documentation
  • New behavior or changes to existing untested code: Ensured that unit tests are added (See Ground Rules).
  • Large PR: Prepare changes in small commits for more convenient review
  • Bug fix: Add regression test for the bug
  • Bug fix: Create Backport PR to latest release

@berland berland self-assigned this Feb 3, 2025
@berland berland added the release-notes:skip If there should be no mention of this in release notes label Feb 3, 2025
@berland berland requested a review from larsevj February 3, 2025 14:02
Copy link

codspeed-hq bot commented Feb 3, 2025

CodSpeed Performance Report

Merging #9946 will not alter performance

Comparing berland:rm_dead_test_setup (acac0f8) with main (5f7a11a)

Summary

✅ 25 untouched benchmarks

@berland berland merged commit aaa613d into equinor:main Feb 3, 2025
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-notes:skip If there should be no mention of this in release notes
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants