Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure consistent log levels in integration tests #6922

Merged
merged 1 commit into from
Jan 10, 2024
Merged

Ensure consistent log levels in integration tests #6922

merged 1 commit into from
Jan 10, 2024

Conversation

berland
Copy link
Contributor

@berland berland commented Jan 10, 2024 •
edited
Loading

Some tests were moved from unit_tests to integration_tests in a810eb0 that were sensitive to log level details. This dependency was not triggered in Github actions workflows but in komodo bleeding nightly tests.

Issue
Resolves #6863

Approach
Move logging fixture from unit_tests to one level up, thus ensuring this in all tests.

  • PR title captures the intent of the changes, and is fitting for release notes.
  • Added appropriate release note label
  • Commit history is consistent and clean, in line with the contribution guidelines.
  • Make sure tests pass locally (after every commit!)

When applicable

  • When there are user facing changes: Updated documentation
  • New behavior or changes to existing untested code: Ensured that unit tests are added (See Ground Rules).
  • Large PR: Prepare changes in small commits for more convenient review
  • Bug fix: Add regression test for the bug
  • Bug fix: Create Backport PR to latest release

@berland
Ensure consistent log levels in integration tests
1331735 
Some tests were moved from unit_tests to integration_tests in /a810eb0f8715e182d4e1b1dc1636356b97023711
that depend on log level details. This dependency was not triggered in Github actions workflows
but in komodo bleeding nightly tests.
xjules
xjules approved these changes Jan 10, 2024
View reviewed changes
Copy link
Contributor

@xjules xjules left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beautiful! 🚀

@berland berland added bug release-notes:skip If there should be no mention of this in release notes labels Jan 10, 2024
@berland berland enabled auto-merge (squash) January 10, 2024 14:22
@berland berland merged commit f27f7f8 into equinor:main Jan 10, 2024
39 of 43 checks passed
@berland berland deleted the ensure_log_level_pytest branch September 17, 2024 07:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xjules xjules xjules approved these changes

Assignees
No one assigned
Labels
bug release-notes:skip If there should be no mention of this in release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix tests/integration_tests/cli/test_integration_cli.py::test_failing_job_cli_error_message
2 participants
@berland @xjules