Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIx usage of manylinux2014 in the github actions build workflow #3430

Merged
merged 1 commit into from
May 24, 2022

Conversation

verveerpj
Copy link
Contributor

@verveerpj verveerpj commented May 24, 2022

Issue
Resolves #3282

Approach
Solution can be found in: pypa/manylinux#1309

Pre review checklist

  • Added appropriate release note label
  • PR title captures the intent of the changes, and is fitting for release notes.
  • Commit history is consistent and clean, in line with the contribution guidelines.

Adding labels helps the maintainers when writing release notes. This is the list of release note labels.

@verveerpj verveerpj self-assigned this May 24, 2022
@verveerpj verveerpj marked this pull request as draft May 24, 2022 12:39
@codecov-commenter
Copy link

Codecov Report

Merging #3430 (2de2bca) into main (65f1334) will decrease coverage by 0.00%.
The diff coverage is n/a.

❗ Current head 2de2bca differs from pull request most recent head 5cc0c72. Consider uploading reports for the commit 5cc0c72 to get more accurate results

@@            Coverage Diff             @@
##             main    #3430      +/-   ##
==========================================
- Coverage   65.27%   65.27%   -0.01%     
==========================================
  Files         603      603              
  Lines       47728    47728              
  Branches     4234     4234              
==========================================
- Hits        31155    31154       -1     
+ Misses      15217    15216       -1     
- Partials     1356     1358       +2     
Impacted Files Coverage Δ
libres/lib/res_util/block_fs.cpp 67.07% <0.00%> (-0.62%) ⬇️
ert/data/record/_transformation.py 89.04% <0.00%> (+0.47%) ⬆️

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@verveerpj verveerpj added maintenance Not a bug now but could be one day, repaying technical debt release-notes:maintenance Automatically categorise as maintenance change in release notes labels May 24, 2022
@verveerpj verveerpj changed the title WIP: Remove pinning of manylinux Remove pinning of manylinux May 24, 2022
@verveerpj verveerpj force-pushed the remove-manylinux-pinning branch from 5cc0c72 to ccf97df Compare May 24, 2022 13:20
@verveerpj verveerpj changed the title Remove pinning of manylinux FIx usage of manylinux2014 in the github actions build workflow May 24, 2022
@verveerpj verveerpj marked this pull request as ready for review May 24, 2022 13:50
Copy link
Collaborator

@sondreso sondreso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nice find! 🕵️

@verveerpj verveerpj merged commit fdd477b into main May 24, 2022
@verveerpj verveerpj deleted the remove-manylinux-pinning branch May 24, 2022 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Not a bug now but could be one day, repaying technical debt release-notes:maintenance Automatically categorise as maintenance change in release notes
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Remove pinning of manylinux2014
3 participants