Rename job to step in _ert/forward_model_runner #10013
Merged
+126
−127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit will change almost all occurences of the string job to the correct term step, except for where it is regarded as a potentially breaking change for users.
berland
added
the
release-notes:refactor
CodSpeed Performance ReportMerging #10013 will improve performances by 11%Comparing Summary
Benchmarks breakdown
|
| @@ -85,35 +85,35 @@ class ForwardModelStep: | |||
| MEMORY_POLL_PERIOD = 5 # Seconds between memory polls | |||
|
|
|||
| def __init__( | |||
| self, job_data: ForwardModelStepJSON, index: int, sleep_interval: int = 1 | |||
| self, step_data: ForwardModelStepJSON, index: int, sleep_interval: int = 1 | |||
There was a problem hiding this comment.
Separate issue, but could consider calling this either just step or step_json. The postfix _data doesn't really add anything.
There was a problem hiding this comment.
Agree, but it needs some thinking, so postponing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit will change almost all occurences of the string job to the correct term step, except for where it is regarded as a potentially breaking change for users.
git rebase -i main --exec 'just rapid-tests')When applicable