Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add basic unit tests for factbox #291

Closed
SvSven opened this issue May 5, 2021 · 1 comment
Closed

add basic unit tests for factbox #291

SvSven opened this issue May 5, 2021 · 1 comment
Assignees
@SvSven
Labels
⚙️ task A single task. If linked to a user story it is a sub-task. 🛠 Technical Technical stuffs like reducing debt, refactor or improve code base

Comments

@SvSven
Copy link
Contributor

SvSven commented May 5, 2021

Related: #246

While we shouldn't write tests that rely too much on knowledge of implementation, we should add a couple of basic ones for the factbox:

  • hasColumns prop
  • imagePosition prop
  • dynamicHeight prop
@SvSven SvSven added 🛠 Technical Technical stuffs like reducing debt, refactor or improve code base ⚙️ task A single task. If linked to a user story it is a sub-task. labels May 5, 2021
@SvSven SvSven self-assigned this May 5, 2021
@SvSven
Copy link
Contributor Author

SvSven commented May 5, 2021

Testing for CSS styles is currently a real pain due to some problems with v7 of jest-styled-components causing components to fail with "No style rules found on passed Component".

This has been an ongoing issue since January 2020 - see: styled-components/jest-styled-components#294

SvSven added a commit that referenced this issue May 5, 2021
@SvSven
✅ add FactBox tests for extending styles (#291)
20e91f0
@SvSven SvSven closed this as completed May 6, 2021
vnys pushed a commit that referenced this issue Jun 9, 2021
@SvSven
✅ add FactBox tests for extending styles (#291)
8588245
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@SvSven SvSven

Labels
⚙️ task A single task. If linked to a user story it is a sub-task. 🛠 Technical Technical stuffs like reducing debt, refactor or improve code base
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@SvSven