Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge duplicate usePrefersReducedMotion hook to one #2475

Closed
BorghildSelle opened this issue Aug 22, 2024 · 0 comments
Closed

Merge duplicate usePrefersReducedMotion hook to one #2475

BorghildSelle opened this issue Aug 22, 2024 · 0 comments
Assignees
@millianapia
Labels
🛠 Technical Technical stuffs like reducing debt, refactor or improve code base

Comments

@BorghildSelle
Copy link
Contributor

BorghildSelle commented Aug 22, 2024 •
edited
Loading

We have two sePrefersReducedMotion hooks, merge into one with taking the Accordion/hooks line with isRenderingOnServer into the common/hooks that adds a change listener.
And update import references in the project
@BorghildSelle BorghildSelle added the 🛠 Technical Technical stuffs like reducing debt, refactor or improve code base label Aug 22, 2024
millianapia added a commit that referenced this issue Sep 12, 2024
@millianapia
🔥 Remove unused hook #2475
ac42c51
@millianapia millianapia self-assigned this Sep 12, 2024
millianapia added a commit that referenced this issue Sep 24, 2024
@millianapia
🔥 Remove unused hook #2475 (#2518)
694fdb2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@millianapia millianapia

Labels
🛠 Technical Technical stuffs like reducing debt, refactor or improve code base
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@millianapia @BorghildSelle