Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Topic and event page promotion giving different widths on the same page #2420

Closed
meols opened this issue Jul 15, 2024 · 3 comments
Closed

Topic and event page promotion giving different widths on the same page #2420

meols opened this issue Jul 15, 2024 · 3 comments
Assignees
@millianapia
Labels
🐛 bug Something isn't working

Comments

@meols
Copy link
Collaborator

meols commented Jul 15, 2024 •
edited
Loading

On prod on the Our locations page and on dev on the events page we see different widths on the promotions.
image.png
image.png
image.png
@meols meols changed the title Topic page promotion giveing different widths on the same page Topic page promotion giving different widths on the same page Jul 15, 2024
@meols meols added the 🐛 bug Something isn't working label Jul 15, 2024
@meols meols changed the title Topic page promotion giving different widths on the same page Topic and event page promotion giving different widths on the same page Jul 15, 2024
@millianapia millianapia self-assigned this Jul 16, 2024
millianapia added a commit that referenced this issue Jul 16, 2024
@millianapia
🐛 Add check for singlepromotion #2420
7b63667
@millianapia
Copy link
Contributor

@meols fixed the events not toggling to a singlepromotion, but i still can not recreate the topic promotions that you found in prod at /where-we-are. Will take a look tomorrow as well

@meols
Copy link
Collaborator Author

meols commented Aug 16, 2024

@millianapia - should the widths be different with or without coloured background?
(lagt inn langt nede på denne siden. https://studiov3-global-development-equinor-web-sites-dev.c2.radix.equinor.com/global-development/desk/topicContent;d0b57050-7f22-434d-97b3-ceb8324719e1)
image.png

millianapia added a commit that referenced this issue Aug 19, 2024
@millianapia
🔇 Remove console.log #2420
820876f
millianapia added a commit that referenced this issue Aug 19, 2024
@millianapia
🐛 Adding noInvert prop for card with coloredbackground #2420
a2ceb98
@millianapia
Copy link
Contributor

at this moment, this is not a bug, as the width changes with the content. Other than that, you can test if the text inverts color for title

millianapia added a commit that referenced this issue Sep 25, 2024
@millianapia
🐛 Add check for singlepromotion #2420 (#2424)
ba5ed10 
* 🐛 Add check for singlepromotion #2420

* 🔇 Remove console.log #2420

* 🐛 Adding noInvert prop for card with coloredbackground #2420
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@millianapia millianapia

Labels
🐛 bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@millianapia @meols