Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Magazine tags are not displayed correctly depending on screen size #1574

Closed
fernandolucchesi opened this issue Mar 29, 2023 · 9 comments
Closed

Magazine tags are not displayed correctly depending on screen size #1574

fernandolucchesi opened this issue Mar 29, 2023 · 9 comments
Assignees
@millianapia
Labels
🐛 bug Something isn't working 🍌 low hanging fruit 🚀 ready to deploy Use this if issue is ready to be deployed

Comments

@fernandolucchesi
Copy link
Contributor

image.png
@millianapia
Copy link
Contributor

what is the correct display? it should be a breakpoint for phones or at least tablets to be horizontal-scrollable ref #1380

@fernandolucchesi
Copy link
Contributor Author

It is a scrollable component, let's leave it as it is for now...

@NickHaggerty1
Copy link
Collaborator

Screenshot 2023-05-16 at 13.19.43.png

@NickHaggerty1
Copy link
Collaborator

Screenshot 2023-05-16 at 13.19.50.png

@NickHaggerty1
Copy link
Collaborator

We could also explore a couple of the above options to make it clearer there is more to read and a user can scroll.

@millianapia millianapia self-assigned this Jun 20, 2024
@BorghildSelle
Copy link
Contributor

Agreed to update the magazine cards to use new card component, similar to promotions
where arrow is at the bottom right and hover on title shows underline
the tags can be a comma-separated list
image

millianapia added a commit that referenced this issue Jun 25, 2024
@millianapia
🎨 Change tag overflow design #1574
f0a2299
@millianapia
Copy link
Contributor

@NickHaggerty1 changed after revised design, can you confirm

@millianapia
Copy link
Contributor

@meols bump

@meols
Copy link
Collaborator

meols commented Jul 18, 2024

Looks good to me 👍

millianapia added a commit that referenced this issue Aug 6, 2024
@millianapia
Magazine tags are not displayed correctly depending on screen size #1574
7a007f0 
 (#2384)

* ✨Add arrow on overflowing magazine tags#1574

* 🎨  Change tag overflow design #1574
@millianapia millianapia added the 🚀 ready to deploy Use this if issue is ready to be deployed label Aug 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@millianapia millianapia

Labels
🐛 bug Something isn't working 🍌 low hanging fruit 🚀 ready to deploy Use this if issue is ready to be deployed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@millianapia @fernandolucchesi @meols @BorghildSelle @NickHaggerty1