Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: icon id for next.js #3706

Merged
merged 5 commits into from
Dec 13, 2024
Merged

fix: icon id for next.js #3706

merged 5 commits into from
Dec 13, 2024

Conversation

sebastianvitterso
Copy link
Contributor

Does two things:

  1. Updates custom useId hook to be stable (actually just return an increasing number).
  2. Make use of the updated useId hook in Icon.tsx for title id.

Closes #3705, see that for more details on "why".

oddvernes
oddvernes requested changes Dec 13, 2024
View reviewed changes
Copy link
Collaborator

@oddvernes oddvernes left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just fix the thw things i commented on 👍

@oddvernes oddvernes merged commit 7e923a1 into equinor:develop Dec 13, 2024
6 checks passed
@sebastianvitterso sebastianvitterso deleted the fix/icon-id-for-next branch December 14, 2024 09:33
@sebastianvitterso sebastianvitterso mentioned this pull request Jan 15, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oddvernes oddvernes oddvernes approved these changes

@vnys vnys Awaiting requested review from vnys vnys is a code owner

@torleifhalseth torleifhalseth Awaiting requested review from torleifhalseth torleifhalseth is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@sebastianvitterso @oddvernes