Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛💄Menu: implement [popover] #3583

Merged
merged 5 commits into from
Aug 13, 2024
Merged

Conversation

oddvernes
Copy link
Collaborator

@oddvernes oddvernes commented Aug 13, 2024

resolves #3580

  • use popover attribute in menu
  • fix an issue where when Autocomplete is inside a Menu, options were unclickable
  • add missing role="group" to Menu.Section after jest axe test failed (I think the tests never rendered the full menu until i refactored it to use popover)

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.
snapshot
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Autocomplete inside Menu unusable since @equinor/eds-core-react 0.38
1 participant