Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

📝Update button documentation for fullWidth #3093

Merged
merged 2 commits into from
Oct 12, 2023
Merged

📝Update button documentation for fullWidth #3093

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a93eb57
📝Update button documentation for fullWidth
oddvernes Oct 6, 2023
ca9f75c
slightly reword description
oddvernes Oct 10, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/eds-core-react/src/components/Button/Button.docs.mdx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,7 +115,7 @@ Tooltip accessible for people using keyboard navigation, as the button is still
<Canvas of={ComponentStories.WithTooltip} />

### Full width
Use boolean prop `fullWidth`
When stretching a button beyond its intrinsic width, the `fullWidth` prop can be used to position icon at the edge.

<Canvas of={ComponentStories.FullWidth} />

Expand Down
13 changes: 12 additions & 1 deletion packages/eds-core-react/src/components/Button/Button.stories.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -286,7 +286,18 @@ WithTooltip.storyName = 'Disabled buttons and tooltip'

export const FullWidth: StoryFn<ButtonProps> = () => (
<>
<Button fullWidth>Primary</Button>
<Button fullWidth>
<Icon data={refresh} size={16}></Icon>
Fullwidth
</Button>
<Button fullWidth>
Fullwidth
<Icon data={refresh} size={16}></Icon>
</Button>
<Button>
<Icon data={refresh} size={16}></Icon>
not Fullwidth
</Button>
</>
)
FullWidth.storyName = 'Full width'
Expand Down
2 changes: 1 addition & 1 deletion packages/eds-core-react/src/components/Button/Button.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -163,7 +163,7 @@ export type ButtonProps = {
* @default 'button'
*/
type?: string
/** FullWidth (stretched) button */
/** Floats icon to the side if button is stretched beyond its intrinsic width */
fullWidth?: boolean
} & ButtonHTMLAttributes<HTMLButtonElement>

Expand Down