Upgrade to React 18 #2510
Merged
Upgrade to React 18 #2510
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mimarz
force-pushed
the
chore/MIM-2474-react-18
branch
from
08d4a2d to
fa06300
Compare
|
Finally! Checks are green! 🙏 |
mimarz
force-pushed
the
chore/MIM-2474-react-18
branch
from
5eb737a to
d025a59
Compare
This was referenced Oct 5, 2022
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #2474
I have published these changes to the test Storybook for testing: https://eds-storybook-react-test.azurewebsites.net/
Tested with our storybook test and locally downstream with pack of eds-core-react. Everything seems to work fine, and I couldn't find any bugs (apart from the know with downshift). I guess it speaks for its self since we treat react as a peer-deps, a lot of our users are already using eds-core-react with React 18, I think we would have heard by now if there were any problems with that.
The biggest change with this PR is then that our development environment is now using React 18. To begin with we should refrain from using new React 18 hooks/utils until its more adpoted.
Only nuisance that still persists is that Storybook hasn't completely supported React 18 yet, so we get this error message in SB.