-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ elevation options to Card/Banner/TopBar #2313
Changes from 7 commits
233cfe1
007ab6e
d0d1f4b
7a430a9
c9cbb49
73088ca
6533837
4d609df
48520b7
ac4bef9
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -15,6 +15,9 @@ import { | |
export default { | ||
title: 'Navigation/TopBar', | ||
component: TopBar, | ||
args: { | ||
elevation: 'raised', | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Suggest removing this or set it to There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The example is a sticky topbar though, which is the use case where it should be elevated. Perhaps the main example should not be sticky and move that down as its own story? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. eh, I just removed it |
||
}, | ||
subcomponents: { | ||
Header: TopBar.Header, | ||
CustomContent: TopBar.CustomContent, | ||
|
@@ -38,12 +41,12 @@ const icons = { | |
Icon.add(icons) | ||
|
||
const Wrapper = styled.div.attrs({ tabIndex: 0 })` | ||
height: 100vh; | ||
height: 65vh; | ||
overflow: auto; | ||
` | ||
|
||
const BodyWrapper = styled.div` | ||
height: 1500px; | ||
height: 1000px; | ||
background: #ebebeb; | ||
display: flex; | ||
flex-direction: column; | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the type that users will see in their IDE, so maybe a nicer word,
availableElevations
? Its also a type which means it should start with an Uppercase.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changing it to
AvailableElevations