Fix rowsMax bug #1369
Merged
Fix rowsMax bug #1369
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bug caused by function only triggered by a key event
Still flickers if you delete default text and edit again
mimarz
suggested changes
May 25, 2021
| @@ -14,13 +14,22 @@ export const useAutoResize = ( | |||
| newHeight = Math.max(targetEl.scrollHeight, newHeight) | |||
| if (maxHeight) { | |||
There was a problem hiding this comment.
Is this check necessary as you are already checking it on line 13?
There was a problem hiding this comment.
targetEl.style.height = 'auto' is needed here too, for it to autoresize correctly when user deletes text. It's to rewrite the height when it's set before.
The nested maxHeight check is also needed, as you can see its if parent is !maxHeight || maxHeight > newHeight, this logic is needed for whenever maxHeight > newHeight only
There was a problem hiding this comment.
Improvements fixed and tested so ready again for review @mimarz
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1367