Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(bloom): use aggregate bloom filters in P2P and starknet_subscribeEvents #2405

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

feat(bloom): use aggregate bloom filters in P2P and starknet_subscribeEvents #2405

wants to merge 2 commits into from
+238 −86

Conversation

sistemd
Copy link
Contributor

@sistemd sistemd commented Nov 25, 2024

Add aggregate bloom filter support to P2P code and starknet_subscribeEvents websocket subscription.

@sistemd sistemd requested a review from a team as a code owner November 25, 2024 12:32
kkovaacs
kkovaacs reviewed Nov 27, 2024
View reviewed changes
crates/pathfinder/Cargo.toml Outdated Show resolved Hide resolved
crates/storage/src/connection/event.rs Show resolved Hide resolved
kkovaacs
kkovaacs approved these changes Nov 27, 2024
View reviewed changes
Copy link
Contributor

@kkovaacs kkovaacs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CHr15F0x CHr15F0x CHr15F0x approved these changes

@kkovaacs kkovaacs kkovaacs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sistemd @kkovaacs @CHr15F0x