feat(pathfinder): add tokio-console non-default feature #179
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CHr15F0x
approved these changes
Mar 7, 2022
| [dependencies] | ||
| anyhow = "1.0.44" | ||
| async-trait = "0.1.52" | ||
| # paritys scale codec locks us here | ||
| bitvec = "0.20.4" | ||
| bytes = "1.1.0" | ||
| clap = "2.33.3" | ||
| console-subscriber = { version = "0.1.3", optional = true } |
There was a problem hiding this comment.
Shouldn't the tracing feature be enabled for tokio too?
Mirko-von-Leipzig
suggested changes
Mar 7, 2022
There was a problem hiding this comment.
Good, just the tokio tracing feature as @CHr15F0x mentioned.
When building with this feature enabled pathfinder enables console_subscriber to expose tracing data for tokio-console. NOTE: as per the tokio-console documentation this also requires building with `tokio_unstable` for now, like: ``` RUSTFLAGS="--cfg tokio_unstable" Cargo build --features tokio-console ```
kkovaacs
force-pushed
the
krisztian/tokio-console
branch
from
8004e7c
to
0395366
Compare
Mirko-von-Leipzig
approved these changes
Mar 8, 2022
|
I think you can ignore the clippy for now. I've fixed it in my PR already. |
|
@kkovaacs pls merge 😉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When building with this feature enabled pathfinder enables console_subscriber
to expose tracing data for tokio-console.
NOTE: as per the
tokio-consoledocumentation this also requires buildingwith
tokio_unstablefor now, like: