Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sequencer retry #178

Merged
merged 5 commits into from
Mar 7, 2022
Merged

Sequencer retry #178

merged 5 commits into from
Mar 7, 2022

Conversation

CHr15F0x
Copy link
Member

@CHr15F0x CHr15F0x commented Mar 7, 2022

Adds a universal retry behavior behind each sequencer::Client method. At the moment backoff params are hard coded.

Mirko-von-Leipzig
Mirko-von-Leipzig suggested changes Mar 7, 2022
View reviewed changes
Copy link
Contributor

@Mirko-von-Leipzig Mirko-von-Leipzig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some smaller additions to the tests, but otherwise looks good.

kkovaacs
kkovaacs approved these changes Mar 7, 2022
View reviewed changes
Copy link
Contributor

@kkovaacs kkovaacs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Mirko-von-Leipzig
Mirko-von-Leipzig approved these changes Mar 7, 2022
View reviewed changes
Copy link
Contributor

@Mirko-von-Leipzig Mirko-von-Leipzig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks just the one question.

@CHr15F0x CHr15F0x merged commit 33d60f4 into main Mar 7, 2022
@CHr15F0x CHr15F0x deleted the sequencer_retry branch March 7, 2022 21:46
@Mirko-von-Leipzig Mirko-von-Leipzig mentioned this pull request Mar 9, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kkovaacs kkovaacs kkovaacs approved these changes

@Mirko-von-Leipzig Mirko-von-Leipzig Mirko-von-Leipzig approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@CHr15F0x @kkovaacs @Mirko-von-Leipzig