fix(rpc): starknet_syncing returns wrong value

[Mirko-von-Leipzig]

This was incorrectly routed to chain_id. Also enabled tests for this.

[CHr15F0x]

LGTM, however I think this part doesn't update the value in the static variable:

(state/sync.rs)

                match &mut *SYNC_STATUS.lock().await {
                    SyncStatus::False(_) => {}
                    syn_status @ SyncStatus::Status(mut status) => {
                        status.current_block = block_hash;
                    }
                }

[Mirko-von-Leipzig]

LGTM, however I think this part doesn't update the value in the static variable:

(state/sync.rs)

                match &mut *SYNC_STATUS.lock().await {
                    SyncStatus::False(_) => {}
                    syn_status @ SyncStatus::Status(mut status) => {
                        status.current_block = block_hash;
                    }
                }

Yes, the mut status in the match was causing us to mutate a copy instead of the reference.

[CHr15F0x]

👏