feat: drt now supported by default in the core module #185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
December 15, 2023 17:41
…entifier The EqasimMainModeIdentifier is not removed by this commit.
…core # Conflicts: # ile_de_france/src/test/java/org/eqasim/ile_de_france/TestCorisica.java
sebhoerl
requested changes
Dec 19, 2023
core/src/main/java/org/eqasim/core/simulation/analysis/EqasimAnalysisModule.java
Outdated
Show resolved
Hide resolved
core/src/main/java/org/eqasim/core/simulation/modes/drt/analysis/DrtAnalysisListener.java
Outdated
Show resolved
Hide resolved
sebhoerl
changed the title
added 4 commits
December 19, 2023 18:58
…_core # Conflicts: # ile_de_france/src/test/java/org/eqasim/ile_de_france/TestCorisica.java
…core # Conflicts: # core/src/test/java/org/eqasim/TestSimulationPipeline.java
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The objective of this PR is to natively support DRT in Eqasim. By making use of the recent developments that allow optional modules to be defined in EqasimConfigurator and its subclasses, the DRT module and related functionalities are activated when a MultiModeDrtConfigGroup is detected.
This implementation is compatible with the presence of various DRT modes running simultaneously.
As for the mode choice, besides extending the ModeParameters class with DrtParameters, the following base components are added
Functionality for DRT analysis is also included.
Moreover, two scripts are present to ease the building of drt scenarios
This functionality for creating a DRT scenario and then running it is tested.
In order to use it in one of the use case modules, users can follow an approach analogous to the one present in the related unit test. The minimum requirement consists of a ModeAvailability that allows the agents to use DRT mode. The other mode choice components should be extended if needed.
Alongside the functionality for DRT, this PR also includes the replacing of EqasimMainModeIdentifier by RoutingModeMainModeIdentifier as mentioned in #184.