Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Timer Session Support with :TimerSession Command #29

Merged
merged 4 commits into from
Jul 26, 2024

Conversation

jmartinn
Copy link

@jmartinn jmartinn commented Jul 13, 2024

Description

This pull request introduces a new :TimerSession <session_name> command to the plugin, allowing users to create and manage Pomodoro like sessions. Each session consists of a sequence of timers with predefined durations and names.

Changes

  • Added: :TimerSession <session_name> command.
  • Extended Configuration: Added support for session definitions in the configuration.
  • Implemented Session Handling Logic: Managed the sequence of timers to run one after the other.
  • Updated README: Included documentation for the new command and configuration options.

Related Issue

Closes #27

Comments

Even though I didn't write a specific test for this feature, I tried it myself and it works just fine.

Checklist

  • Code formatted with StyLua.
  • Code linted with luacheck.
  • Wrote the corresponding tests.
  • CHANGELOG updated.

Copy link
Owner

@epwalsh epwalsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great @jmartinn, thank you! I just made a little change to autocomplete the session name or default to the only session when no name is provided.

@epwalsh epwalsh merged commit a926b5e into epwalsh:main Jul 26, 2024
4 checks passed
@jmartinn jmartinn deleted the session-timer branch July 26, 2024 21:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEAT] Pomodoro Technique
2 participants