Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Needed to add vim.notify = require "notify" to get pomo to use nvim-notify. #10

Closed
sebajun9 opened this issue Dec 27, 2023 · 1 comment · Fixed by #11
Closed

Needed to add vim.notify = require "notify" to get pomo to use nvim-notify. #10

sebajun9 opened this issue Dec 27, 2023 · 1 comment · Fixed by #11
Labels
bug Something isn't working

Comments

@sebajun9
Copy link

🐛 Describe the bug

Hey there, going to start with a few caveats. I'm using NvChad and know just enough to get by. I was having some trouble getting pomo to use nvim-notify until I read over the documentation for nvim-notify and saw it required vim.notify = require("notify").

This is the complete entry:

 {
    "epwalsh/pomo.nvim",
    version = "*", -- Recommended, use latest release instead of latest commit
    lazy = true,
    cmd = { "TimerStart", "TimerRepeat" },
    dependencies = {
      -- Optional, but highly recommended if you want to use the "Default" timer
      "rcarriga/nvim-notify",
      config = function()
        require("notify").setup {
          background_colour = "#000000",
        }
        vim.notify = require "notify"
      end,
    },
    opts = {},
  },

The background_colour issue might be unique to NvChad. Everything works well now, thanks for making this plugin!
image

Versions

NVIM v0.9.2
Build type: Release
LuaJIT 2.1.1692716794

0.4.1

@sebajun9 sebajun9 added the bug Something isn't working label Dec 27, 2023
epwalsh added a commit that referenced this issue Dec 27, 2023
@epwalsh
Copy link
Owner

epwalsh commented Dec 27, 2023

Hey @donhn, good catch. #11 provides a fix so that you don't need to patch vim.notify, although it's fine if you do.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants