Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add :ObsidianNewFromTemplate command #621

Merged
merged 13 commits into from
Jul 11, 2024
Merged

Add :ObsidianNewFromTemplate command #621

merged 13 commits into from
Jul 11, 2024

Conversation

malko42
Copy link
Contributor

@malko42 malko42 commented Jun 11, 2024

The goal is to be able to create a new note while using an existing template

Maxime DAFFIS added 2 commits June 11, 2024 18:01
The goal is to be able to create a new note while using an existing
template
Copy link
Owner

@epwalsh epwalsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks pretty good @malko42! Just a few minor comments

lua/obsidian/commands/new_from_template.lua Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
lua/obsidian/commands/new_from_template.lua Outdated Show resolved Hide resolved
@malko42
Copy link
Contributor Author

malko42 commented Jun 18, 2024

This looks pretty good @malko42! Just a few minor comments

Thanks, you're too kind, I just hacked this together from existing functions

Copy link
Owner

@epwalsh epwalsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@malko42, sorry just noticed a few more nit-picky things on my last review. Could you also add a description of this command to the corresponding section in the README with the other commands?

lua/obsidian/commands/new_from_template.lua Outdated Show resolved Hide resolved
lua/obsidian/commands/new_from_template.lua Outdated Show resolved Hide resolved
lua/obsidian/commands/new_from_template.lua Outdated Show resolved Hide resolved
lua/obsidian/commands/new_from_template.lua Outdated Show resolved Hide resolved
malko42 and others added 4 commits June 24, 2024 15:48
- move up picker check to early exit if needed
- unwrap callback
- update README to reflect `:ObsidianNewFromTemplate` addition
@epwalsh epwalsh changed the title [feature] Add ObsidianNewFromTemplate feature Add :ObsidianNewFromTemplate command Jul 11, 2024
Copy link
Owner

@epwalsh epwalsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thank you @malko42!

@epwalsh epwalsh merged commit 837e778 into epwalsh:main Jul 11, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants