feat: detect and handle urls in :ObsidianFollowLink #123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
epwalsh
reviewed
Apr 19, 2023
pbogut
force-pushed
the
better-handling-of-urls
branch
from
8caa556 to
47c7227
Compare
pbogut
force-pushed
the
better-handling-of-urls
branch
from
47c7227 to
ff9b92f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following on #122 .
I have implemented URL detection in
:ObsidianFollowLinkand added a default behavior to ignore URLs to prevent the creation of new files for external links (e.g., 'https://example.com/').Additionally, I have added a new configuration option,
follow_url_func, which allows users to define their own custom behavior when following URLs. This enables users to have more control over what happens when they follow a link, while avoiding the need for:ObsidianFollowLinkto make assumptions or guesses about user preferences, and handling system differences.