Fix bug with cloning templates (#437)

Fixes #436.

CHANGELOG.md

@@ -7,6 +7,10 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ## Unreleased
 
+### Fixed
+
+- Fixed regression with cloning templates where a directory was created instead of a file.
+
 ## [v3.5.2](https://github.com/epwalsh/obsidian.nvim/releases/tag/v3.5.2) - 2024-02-25
 
 ### Fixed

lua/obsidian/templates.lua

@@ -62,7 +62,7 @@ M.clone_template = function(template_name, note_path, client, title)
     return
   end
 
-  note_path:mkdir { parents = true, exist_ok = true }
+  assert(note_path:parent()):mkdir { parents = true, exist_ok = true }
 
   local template_path = Path:new(templates_dir) / template_name
   local template_file = io.open(tostring(template_path), "r")

test/obsidian/path_spec.lua

@@ -238,16 +238,16 @@ describe("Path.mkdir()", function()
   end)
 
   it("should rename a directory", function()
-    local temp_file = Path.temp()
-    temp_file:mkdir()
-    assert.is_true(temp_file:is_dir())
+    local temp_dir = Path.temp()
+    temp_dir:mkdir()
+    assert.is_true(temp_dir:is_dir())
 
     local target = Path.temp()
     assert.is_false(target:exists())
 
-    temp_file:rename(target)
+    temp_dir:rename(target)
     assert.is_true(target:is_dir())
-    assert.is_false(temp_file:is_dir())
+    assert.is_false(temp_dir:is_dir())
 
     target:rmdir()
     assert.is_false(target:exists())