Refactor test_epiparameter() & assert_epiparameter()
#402
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors the
test_epiparameter()andassert_epiparameter()functions by pulling out the body of each function and merging in a new.validate_epiparameter()function, which is called by each of the exported functions.If
.validate_epiparameter()finds invalid components of<epiparameter>objects it surfaces messages whichtest_epiparameter()andassert_epiparameter()use to message or error with, respectively.The unit tests of
test_epiparameter()andassert_epiparameter()have also been simplified.Unifying the bodies of
test_epiparameter()andassert_epiparameter()was suggested in #394.