Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set up infrastructure to translate print() methods #367

Merged
merged 5 commits into from
Aug 14, 2024

Conversation

Bisaloo
Copy link
Member

@Bisaloo Bisaloo commented Aug 13, 2024

Fix #116.

We still need native speakers to do the actual translation, as documented in https://michaelchirico.github.io/potools/articles/translators.html but this sets up the necessary infrastructure.

Copy link
Member

@joshwlambert joshwlambert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks good. Thanks @Bisaloo for adding this.

It would be good to discuss what the process should be around trying to add translations to the packages. I.e. should we add a line to the README about accepting translation contributions, should we be aiming to add translations for a core set of languages within Epiverse (e.g. es, fr)?

@joshwlambert
Copy link
Member

@Bisaloo this PR is still a draft, but from what I can see it is ready to be merged unless we want to include any translations within this PR. Can we set the PR as ready to review so it can be merged?

@Bisaloo Bisaloo marked this pull request as ready for review August 14, 2024 13:45
@Bisaloo
Copy link
Member Author

Bisaloo commented Aug 14, 2024

It would be good to discuss what the process should be around trying to add translations to the packages. I.e. should we add a line to the README about accepting translation contributions, should we be aiming to add translations for a core set of languages within Epiverse (e.g. es, fr)?

Could you share this on the #community channel on slack please? I believe it needs to involve a larger group.

@Bisaloo this PR is still a draft, but from what I can see it is ready to be merged unless we want to include any translations within this PR. Can we set the PR as ready to review so it can be merged?

Sounds good to me. It was marked as draft to insist on the fact it was low pressure and could easily be delayed/closed if it didn't seem like the best solution.

@joshwlambert
Copy link
Member

The test-coverage workflow is failing and has been sporadically failing since #366. It doesn't relate to this PR so I will go ahead and merge it, and then figure out a solution to apply in a separate PR.

@joshwlambert joshwlambert merged commit f49e61c into main Aug 14, 2024
8 of 9 checks passed
@joshwlambert joshwlambert deleted the translation-infra branch August 14, 2024 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make print() method available in other languages
2 participants