-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set up infrastructure to translate print() methods #367
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All looks good. Thanks @Bisaloo for adding this.
It would be good to discuss what the process should be around trying to add translations to the packages. I.e. should we add a line to the README about accepting translation contributions, should we be aiming to add translations for a core set of languages within Epiverse (e.g. es, fr)?
@Bisaloo this PR is still a draft, but from what I can see it is ready to be merged unless we want to include any translations within this PR. Can we set the PR as ready to review so it can be merged? |
37986aa
to
82001c1
Compare
Could you share this on the #community channel on slack please? I believe it needs to involve a larger group.
Sounds good to me. It was marked as draft to insist on the fact it was low pressure and could easily be delayed/closed if it didn't seem like the best solution. |
The |
Fix #116.
We still need native speakers to do the actual translation, as documented in https://michaelchirico.github.io/potools/articles/translators.html but this sets up the necessary infrastructure.