Remove <vb_epidist> class and methods
#359
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jul 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses #342 and #93 by removing the
<vb_epidist>class and it's associated methods.After two minor version releases of the {epiparameter} R package it was agreed (see #93) that the
<vb_epidist>class was not providing any additional functionality to the package, had no known use-cases, and was a burden to maintain and develop around as it interacted with<epidist>methods (e.g.print.epidist()).The constructor, validator, helper functions and S3 methods for
<vb_epidist>as well as it's mentioning in documentation, have been removed.It is possible that the logic that was in the class validator (
validate_vb_epidist()) could be written up into a vignette to help users that want to handle both intrinsic and extrinsic parameters for vector-borne diseases, but this is not done in this PR.