Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update <epidist> utility functions #175

Merged
merged 5 commits into from
Sep 5, 2023
Merged

Update <epidist> utility functions #175

merged 5 commits into from
Sep 5, 2023

Conversation

joshwlambert
Copy link
Member

This PR addresses comments from the full package review (PR #151).

The main changes are:

  • Removing possible_epidist_params() (and it's associated documentation and tests)
  • Adding information from possible_epidist_params() to the documentation of epidist()
  • Removing prob_dist_params argument from calc_dist_params() as it was not needed
  • Removing input checking from calc_dist_params() as it is already verified in the higher level functions exposed to the user (i.e. exported functions)

Small, non-functional, updates have been made to several other <epidist> utility functions.

@joshwlambert joshwlambert merged commit 173ff29 into main Sep 5, 2023
8 of 9 checks passed
@joshwlambert joshwlambert deleted the updt_epidist_utils branch September 5, 2023 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant