-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use <bibentry>
for handling citations
#168
Conversation
The R CMD check fails on ubuntu (devel), at the {vdiffr} install stage. I believe this is due to the issue logged here: r-lib/vdiffr#137. I will assume it is fine to merge this without waiting for this individual check to pass, and if the issue persists over time potentially {vdiffr} can be removed from the package. |
@Bisaloo I'm going to merge this PR now in order to not block other developments. Please feel free to leave any comments on the changes and I will address them in a separate PR. |
9 Lauer_etal | ||
10 Linton_etal | ||
11 Linton_etal | ||
12 Linton_etal |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tangential to this PR but are there any plans to list all authors instead of using etal
? It would be especially useful if authors want to use the bibtex citation string directly in their manuscript or reference manager.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, the plan is to store the all bibliographic information. I left it as just the shortened author list for this PR to get the changes into main quicker. I think that the tabular (csv) format is not conducive to a list of names (e.g. one cell for all authors which are semicolon separated perhaps, because one cell per author would not work). Instead using JSON where the authors could be listed within the bibliography of each entry might be better. What do you think to changing from csv to a more structured data format? I don't foresee it being more difficult to maintain or expand a JSON database than csv.
This PR addresses and closes #156.
This PR updates the citation information in the parameter library and therefore in the
<epiparam>
class, and uses<bibentry>
objects to handle citation information in<epidist>
objects.The data dictionary is updated to check the new
title
andjournal
fields in the library.Tests and documentation are updated to correspond with the functional updates in the package.