Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE REQUEST] Change autoscaling_group approach in AWS provider in favor of plain VM creation. #2853

Closed
10 of 20 tasks
seriva opened this issue Jan 11, 2022 · 1 comment
Closed
10 of 20 tasks

Comments

@seriva
Copy link
Collaborator

seriva commented Jan 11, 2022

Is your feature request related to a problem? Please describe.
Currently for AWS we use autoscaling_groups to create a set of VMs for a given component group. This approach however has several issues as we cant guaranty the order of the VMs when changing/updating the cluster. This in turn causes issues with scaling some of the components in our cluster.

Describe the solution you'd like
We would like to have the same approach as we have in the Azure provider where we create the VMs ourselves.

Also it would be nice to include the use_network_security_groups feature which is currently unimplemented in AWS. In shirt this should disable the use of any network security rules for the VPC and subnets.

Describe alternatives you've considered
None

Additional context
None


DoD checklist

  • Changelog
    • updated
    • not needed
  • COMPONENTS.md
    • updated
    • not needed
  • Schema
    • updated
    • not needed
  • Backport tasks
    • created
    • not needed
  • Documentation
    • added
    • updated
    • not needed
  • Feature has automated tests
  • Automated tests passed (QA pipelines)
    • apply
    • upgrade
    • backup/restore
  • Idempotency tested
  • All conversations in PR resolved
  • Solution meets requirements and is done according to design doc
  • Usage compliant with license
@przemyslavic
Copy link
Collaborator

✔️ creating plain VMs on AWS (without autoscaling groups)
✔️ added sorting in inventory (hostnames are created the same as for Azure)
✔️ added support for use_network_security_groups. When set to false, ssh is not allowed.
✔️ added names/tags for resources
✔️ added support for data disks

Upgrades from older clusters are not supported.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants